lkml.org 
[lkml]   [2017]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] iio: adc: Add support for TI ADC1x8s102
From
Date
On 05/03/2017 10:43 AM, Andy Shevchenko wrote:
>>>>>> + .owner = THIS_MODULE,
>>>>>
>>>>> This is redundant I'm pretty sure.
>>>>
>>>> Even in 2017, drivers keep being added that carry such assignments. Can
>>>> you explain when it is needed and when not? Otherwise, I will leave it in.
>>>
>>> The above I'm 100% sure is not needed. It's needed only in cases when
>>> framework / device core doesn't do this for ya.
>>>
>>> In the above case IIRC device core does it once for all.
>
>> Then this is not consistently filtered out in new driver reviews. I can
>> remove it, of course.
>
> Please, remove.
>
> I guess many of new drivers just lack of proper review :-(
>

The kbuild bot will even send automated patches to remove the owner field if
a patch that has the owner field is merged. So definitely remove it.

\
 
 \ /
  Last update: 2017-05-03 10:51    [W:0.038 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site