Messages in this thread | | | From | Bart Van Assche <> | Subject | Re: [PATCH] sd: Ignore sync cache failures when not supported | Date | Wed, 3 May 2017 18:23:50 +0000 |
| |
On Thu, 2017-03-16 at 17:48 +0100, Thierry Escande wrote: > -static int sd_sync_cache(struct scsi_disk *sdkp) > +static int sd_sync_cache(struct scsi_disk *sdkp, int *sense_key) > { > int retries, res; > struct scsi_device *sdp = sdkp->device;
Hello Thierry,
Both in the SCSI spec and in struct scsi_sense_hdr sense keys are declared as eight bit values. So I would appreciate if the sense_key data type would be changed from "int" into "u8". Otherwise this patch looks fine to me.
Thanks,
Bart.
| |