lkml.org 
[lkml]   [2017]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 12/20] drm/sun4i: tcon: Fix tcon channel 1 backporch calculation
    Date
    It seems like what's called a backporch in the datasheet is actually the
    backporch plus the sync period. Fix that in our driver.

    Acked-by: Chen-Yu Tsai <wens@csie.org>
    Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
    ---
    drivers/gpu/drm/sun4i/sun4i_tcon.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/sun4i/sun4i_tcon.c b/drivers/gpu/drm/sun4i/sun4i_tcon.c
    index 1c609d808b86..86a806fae9fb 100644
    --- a/drivers/gpu/drm/sun4i/sun4i_tcon.c
    +++ b/drivers/gpu/drm/sun4i/sun4i_tcon.c
    @@ -262,7 +262,7 @@ void sun4i_tcon1_mode_set(struct sun4i_tcon *tcon,
    SUN4I_TCON1_BASIC2_Y(mode->crtc_vdisplay));

    /* Set horizontal display timings */
    - bp = mode->crtc_htotal - mode->crtc_hsync_end;
    + bp = mode->crtc_htotal - mode->crtc_hsync_start;
    DRM_DEBUG_DRIVER("Setting horizontal total %d, backporch %d\n",
    mode->htotal, bp);
    regmap_write(tcon->regs, SUN4I_TCON1_BASIC3_REG,
    @@ -270,7 +270,7 @@ void sun4i_tcon1_mode_set(struct sun4i_tcon *tcon,
    SUN4I_TCON1_BASIC3_H_BACKPORCH(bp));

    /* Set vertical display timings */
    - bp = mode->crtc_vtotal - mode->crtc_vsync_end;
    + bp = mode->crtc_vtotal - mode->crtc_vsync_start;
    DRM_DEBUG_DRIVER("Setting vertical total %d, backporch %d\n",
    mode->vtotal, bp);
    regmap_write(tcon->regs, SUN4I_TCON1_BASIC4_REG,
    --
    git-series 0.8.11
    \
     
     \ /
      Last update: 2017-05-03 14:06    [W:4.103 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site