Messages in this thread | | | Subject | Re: [PATCH 1/3] ipc: convert ipc_namespace.count from atomic_t to refcount_t | From | Manfred Spraul <> | Date | Sun, 28 May 2017 14:10:40 +0200 |
| |
On 05/27/2017 09:41 PM, Kees Cook wrote: > On Mon, Feb 20, 2017 at 3:29 AM, Elena Reshetova > <elena.reshetova@intel.com> wrote: >> refcount_t type and corresponding API should be >> used instead of atomic_t when the variable is used as >> a reference counter. This allows to avoid accidental >> refcounter overflows that might lead to use-after-free >> situations. >> >> Signed-off-by: Elena Reshetova <elena.reshetova@intel.com> >> Signed-off-by: Hans Liljestrand <ishkamiel@gmail.com> >> Signed-off-by: Kees Cook <keescook@chromium.org> >> Signed-off-by: David Windsor <dwindsor@gmail.com> > Manfred, is this okay by you? I think this should go via -mm... The patch is ok, the refcounters are not in the critical path. I'll try to test the patches and then I would send an 'Acked-by', but this will take some days.
-- Manfred
| |