Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 27 May 2017 19:47:46 +0300 | Subject | Re: [PATCH 05/10] gpio: mockup: improve the debugfs input sanitization |
| |
On Sat, May 27, 2017 at 7:45 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Thu, May 25, 2017 at 11:33 AM, Bartosz Golaszewski <brgl@bgdev.pl> wrote: >> We're currently only checking the first character of the input to the >> debugfs event files, so a string like '0sdfdsf' is valid and indicates >> a falling edge event. >> >> Be more strict and only allow '0', '1', '0\n' & '1\n'. > > Why not to be so strict and use > > kstrtobool_from_user(); > > instead?
Or if you still wish to be strict, ret = kstrtou8_from_user(); if (ret) return ret;
if (val > 1) return -ERANGE;
or alike.
-- With Best Regards, Andy Shevchenko
| |