lkml.org 
[lkml]   [2017]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 13/27] thunderbolt: Read vendor and device name from DROM
On Sat, May 27, 2017 at 6:57 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Fri, May 26, 2017 at 7:09 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
>> The device DROM contains name of the vendor and device among other
>> things. Extract this information and expose it to the userspace via two
>> new attributes.
>
>> +static const char *parse_name(const u8 *data, u8 len)
>
> Hmm... (name)
>
>> +{
>> + char *name;
>> +
>> + name = kmemdup(data, len, GFP_KERNEL);
>
> Since it's ASCII by specification it may make sense to use
>
> sw->..._name = kstrndup(entry->data, sizeof(*header), GFP_KERNEL);

sizeof(*header) - 1, of course.

> if (!sw->..._name)
> return -ENOMEM;
>
> just in place, instead of this entire function.
>
>> + if (name)
>> + name[len - 1] = '\0';
>> + return name;
>> +}
>> +
>> +static int tb_drom_parse_entry_generic(struct tb_switch *sw,
>> + struct tb_drom_entry_header *header)
>> +{
>> + const struct tb_drom_entry_generic *entry =
>> + (const struct tb_drom_entry_generic *)header;
>> +
>> + switch (header->index) {
>> + case 1:
>> + /* Length includes 2 bytes header so remove it before copy */
>> + sw->vendor_name = parse_name(entry->data,
>> + header->len - sizeof(*header));
>> + if (!sw->vendor_name)
>> + return -ENOMEM;
>> + break;
>> +
>> + case 2:
>> + sw->device_name = parse_name(entry->data,
>> + header->len - sizeof(*header));
>> + if (!sw->device_name)
>> + return -ENOMEM;
>> + break;
>> + }
>> +
>> + return 0;
>> +}
>
> --
> With Best Regards,
> Andy Shevchenko



--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-05-27 17:59    [W:0.080 / U:0.192 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site