Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 27 May 2017 16:48:35 +0300 | Subject | Re: [PATCH v3 09/10] gpio-exar/8250-exar: Make set of exported GPIOs configurable |
| |
On Fri, May 26, 2017 at 7:02 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote: > On the SIMATIC, IOT2040 only a single pin is exportable as GPIO, the > rest is required to operate the UART. To allow modeling this case, > expand the platform device data structure to specify a (consecutive) pin > subset for exporting by the gpio-exar driver.
> + unsigned int first_pin;
> + if (device_property_read_u32(&pdev->dev, "first_pin", &first_pin) < 0 ||
And again, we need to follow the rules of the device property bindings. (No underscores - use dashes; name should be registered).
Without Rafael's / Mika's and Rob's opinions I would not go with a such name even for internal property.
DWC3 (USB) for example is still using "linux," prefix. I dunno if it's the case here, I mean can or can't we use similar approach.
> + device_property_read_u32(&pdev->dev, "npins", &npins) < 0)
"ngpios"
-- With Best Regards, Andy Shevchenko
| |