lkml.org 
[lkml]   [2017]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 3/6] stmmac: pci: Make stmmac_pci_find_phy_addr truly generic
On Fri, May 26, 2017 at 7:07 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> Move the special case for the early Galileo firmware into
> quark_default_setup. This allows to use stmmac_pci_find_phy_addr for
> non-quark cases.

> ret = stmmac_pci_find_phy_addr(pdev, info);
> - if (ret < 0)
> - return ret;
> + if (ret < 0) {
> + /*
> + * Galileo boards with old firmware don't support DMI. We always
> + * use 1 here as PHY address, so at least the first found MAC
> + * controller would be probed.
> + */
> + if (!dmi_get_system_info(DMI_BOARD_NAME))
> + ret = 1;
> + else
> + return ret;

Perhaps

/* Return error to the caller on DMI enabled boards */
if (dmi_...)
return ret;
/*
* Comment goes here, I suppose.
*/
ret = 1;

> + }

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2017-05-27 15:26    [W:0.170 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site