Messages in this thread | | | Date | Fri, 26 May 2017 22:51:38 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v2 1/3] EDAC: mv64x60: remove unused variable |
| |
On Thu, May 18, 2017 at 08:31:33PM +1200, Chris Packham wrote: > Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > --- > drivers/edac/mv64x60_edac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/edac/mv64x60_edac.c b/drivers/edac/mv64x60_edac.c > index 14b7e7b71eaa..454e1e26ee7c 100644 > --- a/drivers/edac/mv64x60_edac.c > +++ b/drivers/edac/mv64x60_edac.c > @@ -853,8 +853,6 @@ static struct platform_driver * const drivers[] = { > > static int __init mv64x60_edac_init(void) > { > - int ret = 0; > - > printk(KERN_INFO "Marvell MV64x60 EDAC driver " MV64x60_REVISION "\n"); > printk(KERN_INFO "\t(C) 2006-2007 MontaVista Software\n"); > /* make sure error reporting method is sane */ > --
Looks like the logic behind that ret variable is to catch the retval of platform_register_drivers() and test it to return early. And then issue the printks and assign edac_op_state only in the success case.
Please do that instead.
Thanks.
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |