Messages in this thread | | | Subject | Re: [PATCH v4 1/2] mfd: intel_soc_pmic: Select designware i2c-bus driver | From | Hans de Goede <> | Date | Fri, 26 May 2017 13:11:53 +0200 |
| |
Hi,
On 22-05-17 12:57, Lee Jones wrote: > On Mon, 15 May 2017, Hans de Goede wrote: > >> The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be >> available before other drivers using it are loaded, which is why >> INTEL_SOC_PMIC is a bool. >> >> Just having the driver is not enough, the driver for the i2c-bus must >> also be built in, to ensure this, this patch adds a select for it. >> >> This fixes errors like these during boot: >> >> mmc0: SDHCI controller on ACPI [80860F14:00] using ADMA >> ACPI Error: No handler for Region [REGS] (ffff93543b0cc3a8) [UserDefinedRegion] (20170119/evregion-166) >> ACPI Error: Region UserDefinedRegion (ID=143) has no handler (20170119/exfldio-299) >> ACPI Error: Method parse/execution failed [\_SB.PCI0.I2C7.PMI5.GET] (Node ffff93543b0cde10), AE_NOT_EXIST (20170119/psparse-543) >> ACPI Error: Method parse/execution failed [\_SB.PCI0.SHC1._PS0] (Node ffff93543b0b5cd0), AE_NOT_EXIST (20170119/psparse-543) >> acpi 80860F14:02: Failed to change power state to D0 >> >> While at it this patch also changes the human readable name of the Kconfig >> option to make clear the INTEL_SOC_PMIC option selects support for the >> Intel Crystal Cove PMIC and documents why this is a bool. >> >> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com> > > Would be good to get an Ack by the users/maintainers of this driver. > >> --- >> Note this patch will partially conflicts with (contains the same changes as) >> a patch in Andy Shevchenko's tree. > > Has this been sorted now?
Yes, sorry I should have dropped this bit.
> >> --- >> Changes in v2: >> -Fix Kconfig depends and selects to fix warning reported by kbuild test robot >> -Improve commit msg (add example of ACPI errors this avoids) >> Changes in v3: >> -No changes >> Changes in v4: >> -Add explanation why this is a bool and why it selects i2c-designwaree >> to the help text rather then as comments in the Kconfig >> --- >> drivers/mfd/Kconfig | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >> index 1b6a83a4a114..61ebda81e134 100644 >> --- a/drivers/mfd/Kconfig >> +++ b/drivers/mfd/Kconfig >> @@ -448,17 +448,24 @@ config LPC_SCH >> >> config INTEL_SOC_PMIC >> bool "Support for Crystal Cove PMIC" >> - depends on GPIOLIB >> - depends on I2C=y >> + depends on HAS_IOMEM >> + select GPIOLIB >> + select I2C >> select MFD_CORE >> select REGMAP_I2C >> select REGMAP_IRQ >> + select COMMON_CLK >> + select I2C_DESIGNWARE_PLATFORM >> help >> Select this option to enable support for Crystal Cove PMIC >> on some Intel SoC systems. The PMIC provides ADC, GPIO, >> thermal, charger and related power management functions >> on these systems. >> >> + This option is a bool as it provides an ACPI Opregion which must be > > Nit: s/Opregion/OpRegion/
Fixed for v5 (which I will send in a minute).
Regards,
Hans
| |