Messages in this thread | | | Subject | Re: linux-next: build warning after merge of the akpm-current tree | From | Jeff Layton <> | Date | Fri, 26 May 2017 06:16:28 -0400 |
| |
On Fri, 2017-05-26 at 12:43 +1000, Stephen Rothwell wrote: > Hi Andrew, > > After merging the akpm-current tree, today's linux-next build (powerpc > ppc64_defconfig) produced this warning: > > fs/jfs/jfs_metapage.c: In function 'force_metapage': > fs/jfs/jfs_metapage.c:714:2: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result] > write_one_page(page); > ^ > fs/jfs/jfs_metapage.c: In function 'release_metapage': > fs/jfs/jfs_metapage.c:759:4: warning: ignoring return value of 'write_one_page', declared with attribute warn_unused_result [-Wunused-result] > write_one_page(page); > ^ > > Introduced by commit > > f8652aebee02 ("mm: drop "wait" parameter from write_one_page()") > > These call sites were updated for the droppping of the argument, but > not for the addition of __must_check :-( >
(cc'ing Dave...)
Yeah, that's a known issue. When Willy reviewed the patch originally he asked me to add a __must_check there so that JFS would pick up some warnings for this.
JFS really ought to check the return code there and do something sane with it. Dave?
-- Jeff Layton <jlayton@redhat.com>
| |