lkml.org 
[lkml]   [2017]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tpm: vtpm_proxy: Do not run tpm2_shutdown
From
Date
On 05/25/2017 04:44 PM, Jason Gunthorpe wrote:
> On Thu, May 25, 2017 at 04:32:50PM -0400, Stefan Berger wrote:
>
>> It doesn't hang. Everything is torn down immediately. What is primarily
>> annoying are these two log messages:
>> tpm tpm0: tpm_transmit: tpm_send: error -32
>> tpm tpm0: transmit returned -32 while stopping the TPM
> I think it would be better to change the core to suppress that logging
> if the FD is closed.

This particular command will never reach anyone listening on the proxy's
file descriptor since the tear-down only begins when the front- and
backend are closed.
The logging happens somewhere else than where the error occurs. What is
the best way to suppress the logging? Remove it entirely -- probably
not. Return a special error code that doesn't get logged? Return a 2nd
parameter that indicates this condition? It's not clear to me. Why not
just prevent the command from being sent if it will never reach its
intended destination ?

Stefan

>
> Jason
>

\
 
 \ /
  Last update: 2017-05-25 22:54    [W:0.073 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site