lkml.org 
[lkml]   [2017]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5][v2] staging: fsl-mc: fix several checkpath.pl warnings
On Mon, May 22, 2017 at 03:09:31PM +0300, laurentiu.tudor@nxp.com wrote:
> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>

Your subject line is very odd, please use the 'v2' marking properly...

>
> Remove several unneeded #includes, forward
> declarations and fix several issues reported
> by checkpatch.pl --strict, such as:
> - kfree(NULL) is safe and check is not required
> - macro argument reuse may cause possible side effects
> - enclose macro params in parens to avoid precedence issues
> - coding style

These, as always, need to be broken up into one-patch-per-type-of-thing,
you have been in the staging tree long enough to know this :(

Please do this first, then we can consider the rest of the series...

thanks,

greg k-h

\
 
 \ /
  Last update: 2017-05-25 19:00    [W:0.068 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site