Messages in this thread | | | From | Logan Gunthorpe <> | Date | Thu, 25 May 2017 09:53:17 -0600 | Subject | Re: [PATCH v2] um: add dummy ioremap and iounmap functions |
| |
On 25/05/17 09:48 AM, Richard Weinberger wrote: > Which ones are failing? > I thought we killed the problem by making CONFIG_COMPILE_TEST depend on !UML.
None, at the moment. My work is trying to add iomem support to scatter lists and thus I want to call ioremap in scatterlist.c. That's when things fail to build. We could put an '#ifdef HAS_IOMEM' around only the uses, but I thought this approach was cleaner. However, if people would rather I do that, let me know and I will.
> I was never a fan of that approach because in my opinion drivers should have > proper dependencies, including a dependency on HAS_IOMEM.
This doesn't really work when we try to use it in a core library which can't depend on HAS_IOMEM.
Thanks,
Logan
| |