Messages in this thread | | | Date | Thu, 25 May 2017 16:50:42 +0100 | From | Will Deacon <> | Subject | Re: [PATCH 1/1] drivers/perf: arm_pmu_acpi: avoid perf IRQ init when guest PMU is off |
| |
On Thu, May 25, 2017 at 10:49:49AM -0500, Wei Huang wrote: > On 05/25/2017 10:28 AM, Will Deacon wrote: > > On Wed, May 24, 2017 at 09:36:41AM -0500, Wei Huang wrote: > >> if (gicc->flags & ACPI_MADT_PERFORMANCE_IRQ_MODE) > >> trigger = ACPI_EDGE_SENSITIVE; > >> else > >> @@ -58,7 +61,8 @@ static void arm_pmu_acpi_unregister_irq(int cpu) > >> return; > >> > >> gsi = gicc->performance_interrupt; > >> - acpi_unregister_gsi(gsi); > >> + if (gsi) > >> + acpi_unregister_gsi(gsi); > > > > ... but then I don't see how we can get here, so I'll drop this hunk. > > I am OK to drop it. It was added just to be cautious... Do you need > another version from me or you will remove this hunk?
I can drop this hunk, no need to repost.
Thanks,
Will
| |