Messages in this thread | | | Date | Thu, 25 May 2017 13:29:02 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 1/1] printk: add __printf attributes to internal functions |
| |
On Wed 2017-05-24 07:49:50, Nicolas Iooss wrote: > When compiling with -Wsuggest-attribute=format, gcc complains that some > functions in kernel/printk/printk_safe.c transmit their argument to > printf-like functions without having a printf attribute. Silence these > warnings by adding relevant __printf attributes. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> > Acked-by: Petr Mladek <pmladek@suse.com> > --- > v2: add __printf attribute to the definition of vprintk_nmi() which is > used when CONFIG_PRINTK_NMI is not defined.
Sergey, I believe that that your Reviewed-by is still valid even after this small update. Is that true, please?
Best Regards, Petr
| |