lkml.org 
[lkml]   [2017]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 04/10] gpio: mockup: support irqmask and irqunmask
    Date
    Even though this is a testing module, be nice and actually implement
    these functions.

    Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
    ---
    drivers/gpio/gpio-mockup.c | 26 ++++++++++++++++++++------
    1 file changed, 20 insertions(+), 6 deletions(-)

    diff --git a/drivers/gpio/gpio-mockup.c b/drivers/gpio/gpio-mockup.c
    index c17578e..ba8d62a 100644
    --- a/drivers/gpio/gpio-mockup.c
    +++ b/drivers/gpio/gpio-mockup.c
    @@ -41,6 +41,7 @@ enum {
    struct gpio_mockup_line_status {
    int dir;
    bool value;
    + bool irq_enabled;
    };

    struct gpio_mockup_irq_context {
    @@ -142,12 +143,21 @@ static int gpio_mockup_to_irq(struct gpio_chip *chip, unsigned int offset)
    return chip->irq_base + offset;
    }

    -/*
    - * While we should generally support irqmask and irqunmask, this driver is
    - * for testing purposes only so we don't care.
    - */
    -static void gpio_mockup_irqmask(struct irq_data *d) { }
    -static void gpio_mockup_irqunmask(struct irq_data *d) { }
    +static void gpio_mockup_irqmask(struct irq_data *data)
    +{
    + struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
    + struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
    +
    + chip->lines[data->irq - gc->irq_base].irq_enabled = false;
    +}
    +
    +static void gpio_mockup_irqunmask(struct irq_data *data)
    +{
    + struct gpio_chip *gc = irq_data_get_irq_chip_data(data);
    + struct gpio_mockup_chip *chip = gpiochip_get_data(gc);
    +
    + chip->lines[data->irq - gc->irq_base].irq_enabled = true;
    +}

    static struct irq_chip gpio_mockup_irqchip = {
    .name = GPIO_MOCKUP_NAME,
    @@ -178,6 +188,7 @@ static int gpio_mockup_irqchip_setup(struct device *dev,

    for (i = 0; i < gc->ngpio; i++) {
    irq_set_chip(irq_base + i, gc->irqchip);
    + irq_set_chip_data(irq_base + i, gc);
    irq_set_handler(irq_base + i, &handle_simple_irq);
    irq_modify_status(irq_base + i,
    IRQ_NOREQUEST | IRQ_NOAUTOEN, IRQ_NOPROBE);
    @@ -206,6 +217,9 @@ static ssize_t gpio_mockup_event_write(struct file *file,
    chip = priv->chip;
    gc = &chip->gc;

    + if (!chip->lines[priv->offset].irq_enabled)
    + return size;
    +
    if (copy_from_user(&buf, usr_buf, 1))
    return -EFAULT;

    --
    2.9.3
    \
     
     \ /
      Last update: 2017-05-25 10:37    [W:4.235 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site