lkml.org 
[lkml]   [2017]   [May]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: dts: vf610-zii-dev-rev-b: add hi8435 device
On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> >
> > Please keep these labelled nodes sort alphabetically.
>
> Ok
>
> >> + bus-num = <1>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl_dspi2>;
> >> + status = "okay";
> >
> > We usually have 'status' line at the bottom of property list.
>
> Ok
>
> >> + spi-num-chipselects = <2>;
> >> +
> >> + hi8435@1 {
> >
> > Node name should be something generic, while label can be specific
> > model name. The following form might be better.
> >
> > hi8435: sensor@1
>
> Ok
>
> Although the same file, in lines nearby, has m25p128@0 and at93c46d@1.

It seems that I need more eyes to help review.

Shawn

\
 
 \ /
  Last update: 2017-05-25 10:24    [W:0.055 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site