lkml.org 
[lkml]   [2017]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] MIPS: Alchemy: Delete an error message for a failed memory allocation in alchemy_pci_probe()
From
Date
>> +++ b/arch/mips/pci/pci-alchemy.c
>> @@ -377,7 +377,6 @@ static int alchemy_pci_probe(struct platform_device *pdev)
>>
>> ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
>> if (!ctx) {
>> - dev_err(&pdev->dev, "no memory for pcictl context\n");
>> ret = -ENOMEM;
>> goto out;
>> }
>> --
>> 2.13.0
>
> Why are you removing just this one dev_err()?

How do you think about to achieve a small code reduction also for this software module?


> What issue are you trying to address?

Do you find information from a Linux allocation failure report sufficient
for such a function implementation?

Regards,
Markus

\
 
 \ /
  Last update: 2017-05-24 20:16    [W:0.169 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site