lkml.org 
[lkml]   [2017]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] MIPS: ralink: Delete an error message for a failed memory allocation in rt_timer_probe()
Date
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 24 May 2017 18:56:35 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
arch/mips/ralink/timer.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/mips/ralink/timer.c b/arch/mips/ralink/timer.c
index d4469b20d176..efccb444d6bc 100644
--- a/arch/mips/ralink/timer.c
+++ b/arch/mips/ralink/timer.c
@@ -103,10 +103,8 @@ static int rt_timer_probe(struct platform_device *pdev)
struct clk *clk;

rt = devm_kzalloc(&pdev->dev, sizeof(*rt), GFP_KERNEL);
- if (!rt) {
- dev_err(&pdev->dev, "failed to allocate memory\n");
+ if (!rt)
return -ENOMEM;
- }

rt->irq = platform_get_irq(pdev, 0);
if (!rt->irq) {
--
2.13.0
\
 
 \ /
  Last update: 2017-05-24 19:07    [W:0.020 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site