lkml.org 
[lkml]   [2017]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] powerpc: sysdev: simple_gpio: fix Oops in gpio save_regs function
    Date
    of_mm_gpiochip_add_data() generates an Oops for NULL pointer dereference.

    of_mm_gpiochip_add_data() calls mm_gc->save_regs() before
    setting the data, therefore ->save_regs() cannot use gpiochip_get_data()

    Fixes: 937daafca774b ("powerpc: simple-gpio: use gpiochip data pointer")
    Cc: stable@vger.kernel.org

    Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
    ---
    arch/powerpc/sysdev/simple_gpio.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/arch/powerpc/sysdev/simple_gpio.c b/arch/powerpc/sysdev/simple_gpio.c
    index ef470b470b04..6afddae2fb47 100644
    --- a/arch/powerpc/sysdev/simple_gpio.c
    +++ b/arch/powerpc/sysdev/simple_gpio.c
    @@ -75,7 +75,8 @@ static int u8_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)

    static void u8_gpio_save_regs(struct of_mm_gpio_chip *mm_gc)
    {
    - struct u8_gpio_chip *u8_gc = gpiochip_get_data(&mm_gc->gc);
    + struct u8_gpio_chip *u8_gc =
    + container_of(mm_gc, struct u8_gpio_chip, mm_gc);

    u8_gc->data = in_8(mm_gc->regs);
    }
    --
    2.12.0
    \
     
     \ /
      Last update: 2017-05-24 10:02    [W:4.737 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site