lkml.org 
[lkml]   [2017]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/7] RISC-V: arch/riscv Makefile and Kconfigs
    On Tue, 23 May 2017 03:51:24 PDT (-0700), geert@linux-m68k.org wrote:
    > Hi Palmer,
    >
    > On Tue, May 23, 2017 at 2:41 AM, Palmer Dabbelt <palmer@dabbelt.com> wrote:
    >> --- /dev/null
    >> +++ b/arch/riscv/Kconfig
    >> @@ -0,0 +1,300 @@
    >
    >> +config PLIC
    >> + bool "Platform-Level Interrupt Controller"
    >> + default y
    >> + help
    >> + This enables support for the PLIC chip found in standard RISC-V
    >> + systems. The PLIC is the top-most interrupt controller found in
    >> + the system, connected directly to the core complex. All other
    >> + interrupt sources (MSI, GPIO, etc) are subordinate to the PLIC.
    >> +
    >> + If you don't know what to do here, say Y.
    >> +
    >
    > I think this symbol belongs in drivers/irqchip/Kconfig, and the corresponding
    > driver in drivers/irqchip/.

    OK, makes sense.

    https://github.com/riscv/riscv-linux/commit/81e5c9e581c318ea99192d5c1aaf97c197e79272

    I'll batch this up with all the other code review comments for a v2.

    \
     
     \ /
      Last update: 2017-05-25 03:59    [W:5.662 / U:0.488 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site