lkml.org 
[lkml]   [2017]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Question] Mlocked count will not be decreased
From
Date
Hi Vlastimil,

Thanks for comment.
On 2017/5/24 19:52, Vlastimil Babka wrote:
> On 05/24/2017 01:38 PM, Xishi Qiu wrote:
>>>
>>> Race condition with what? Who else would isolate our pages?
>>>
>>
>> Hi Vlastimil,
>>
>> I find the root cause, if the page was not cached on the current cpu,
>> lru_add_drain() will not push it to LRU. So we should handle fail
>> case in mlock_vma_page().
>
> Yeah that would explain it.
>
>> follow_page_pte()
>> ...
>> if (page->mapping && trylock_page(page)) {
>> lru_add_drain(); /* push cached pages to LRU */
>> /*
>> * Because we lock page here, and migration is
>> * blocked by the pte's page reference, and we
>> * know the page is still mapped, we don't even
>> * need to check for file-cache page truncation.
>> */
>> mlock_vma_page(page);
>> unlock_page(page);
>> }
>> ...
>>
>> I think we should add yisheng's patch, also we should add the following change.
>> I think it is better than use lru_add_drain_all().
>
> I agree about yisheng's fix (but v2 didn't address my comments). I don't
> think we should add the hunk below, as that deviates from the rest of
> the design.
>
Sorry, I have sent the patch before your comment. Anyway I will send another version
as your suggestion.

Thanks
Yisheng Xie



\
 
 \ /
  Last update: 2017-05-25 03:08    [W:0.052 / U:1.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site