Messages in this thread | | | Date | Tue, 23 May 2017 14:59:27 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 5/5] kernfs: add exportfs operations |
| |
On Mon, May 22, 2017 at 03:53:09PM -0700, Shaohua Li wrote: > +static struct inode *kernfs_nfs_get_inode(struct super_block *sb, > + u64 ino, u32 generation)
Heh, do we have to name this kernfs_nfs_get_inode()? I think it'd be nice to give it a different name and add a comment explaining the goal of the interface.
Also, I think it probably would be better to make this an optional feature of kernfs. sysfs has no need to provide something like this yet.
Thanks.
-- tejun
| |