lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 1/2] PCI/portdrv: add support for different MSI interrupts for PCIe port services
Date
Hi Christoph

> -----Original Message-----
> From: linux-pci-owner@vger.kernel.org [mailto:linux-pci-
> owner@vger.kernel.org] On Behalf Of Christoph Hellwig
> Sent: 22 May 2017 18:44
> To: Gabriele Paoloni
> Cc: Christoph Hellwig; bhelgaas@google.com; helgaas@kernel.org;
> Linuxarm; linux-pci@vger.kernel.org; lukas@wunner.de; linux-
> kernel@vger.kernel.org; mika.westerberg@linux.intel.com; liudongdong
> (C)
> Subject: Re: [PATCH v3 1/2] PCI/portdrv: add support for different MSI
> interrupts for PCIe port services
>
> On Sun, May 21, 2017 at 03:00:46PM +0000, Gabriele Paoloni wrote:
> >
> > I thought that in your previous review you meant to say that we
> should
> > avoid 2 instances of the same comment (in this patchset I only have
> this
> > instance as I have removed the same comment from patch 2/2...)
>
> No, there is no pointin the comment. The whole point of pci_irq_vector
> is to abstract away from how to get at the interrupt in detail. There
> is no need to comment on this at the callsite. If you think the
> existing documentation for the function is not good enough send a patch
> to improve it there instead of commenting the callsites.

Ok got it. I have just sent out v5 where this is fixed.
Thanks
Gab

\
 
 \ /
  Last update: 2017-05-23 16:27    [W:0.039 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site