lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/5] extcon: Allow extcon drivers to specify the extcon name
Hi Hans,

I'm sorry for late reply.

On 2017년 04월 21일 22:01, Hans de Goede wrote:
> The parent device name is not necessarily always useful, e.g.
> with i2c devices it may simply be e.g.: "0-0022" and it also depends
> on the i2c-bus number which depends on probe ordering.
>
> This commit allows drivers to set their own, more useful name,
> avoiding the problems with some i2c-device names.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/extcon/extcon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index f422a78..f8d3c1b 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1117,7 +1117,8 @@ int extcon_dev_register(struct extcon_dev *edev)
> edev->dev.class = extcon_class;
> edev->dev.release = extcon_dev_release;
>
> - edev->name = dev_name(edev->dev.parent);
> + if (!edev->name)
> + edev->name = dev_name(edev->dev.parent);

I think that the variables of 'struct extcon_dev' should be modified by extcon core.
I don't want to touch the variables of 'struct extcon_dev' by extcon provider driver.

> if (IS_ERR_OR_NULL(edev->name)) {
> dev_err(&edev->dev,
> "extcon device name is null\n");
>


--
Best Regards,
Chanwoo Choi
Samsung Electronics

\
 
 \ /
  Last update: 2017-05-23 11:26    [W:0.118 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site