Messages in this thread | | | From | Arnd Bergmann <> | Date | Tue, 23 May 2017 10:35:46 +0200 | Subject | Re: [PATCH v2 4/5] HID: intel_ish-hid: fix format string for size_t |
| |
On Tue, May 23, 2017 at 1:46 AM, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> wrote: > On Thu, 2017-05-18 at 22:21 +0200, Arnd Bergmann wrote: >> When building for 32-bit architectures, we get a harmless warning: >> >> intel-ish-hid/ishtp-hid-client.c: In function 'process_recv': >> intel-ish-hid/ishtp-hid-client.c:139:7: error: format '%lu' expects >> argument of type 'long unsigned int', but argument 3 has type >> 'unsigned int' [-Werror=format=] >> >> This changes the format string to print size_t variables using %zu >> instead. > Is the ordering of patch correct? > ISH config depends on X86_64, so it would not be enabled for 32 bit > build. > So your patch 5/5 will adding "|| COMPILE_TEST", hence it is building.
Right, that is intentional. Adding ||COMPILE_TEST first would be a regression by introducing the warning on 32-bit allmodconfig builds.
Arnd
| |