lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 092/164] USB: serial: mct_u232: fix big-endian baud-rate handling
    Date
    4.9-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit 26cede343656c0bc2c33cdc783771282405c7fb2 upstream.

    Drop erroneous cpu_to_le32 when setting the baud rate, something which
    corrupted the divisor on big-endian hosts.

    Found using sparse:

    warning: incorrect type in argument 1 (different base types)
    expected unsigned int [unsigned] [usertype] val
    got restricted __le32 [usertype] <noident>

    Fixes: af2ac1a091bc ("USB: serial mct_usb232: move DMA buffers to heap")
    Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Acked-By: Pete Zaitcev <zaitcev@yahoo.com>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/serial/mct_u232.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/usb/serial/mct_u232.c
    +++ b/drivers/usb/serial/mct_u232.c
    @@ -189,7 +189,7 @@ static int mct_u232_set_baud_rate(struct
    return -ENOMEM;

    divisor = mct_u232_calculate_baud_rate(serial, value, &speed);
    - put_unaligned_le32(cpu_to_le32(divisor), buf);
    + put_unaligned_le32(divisor, buf);
    rc = usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0),
    MCT_U232_SET_BAUD_RATE_REQUEST,
    MCT_U232_SET_REQUEST_TYPE,

    \
     
     \ /
      Last update: 2017-05-23 23:41    [W:4.105 / U:0.568 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site