lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 2/3] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC
Hi,

When you repost this, would you mind posting the v4 as a complete separate
thread with a cover letter, i.e.,

[v4 0/3] cover
[v4 1/3] arm64: dts: hi3660: add pcie node
[v4 2/3] PCI: dwc: kirin: add PCIe Driver for HiSilicon Kirin SoC
[v4 3/3] defconfig: PCI: Enable Kirin PCIe defconfig

That makes it much easier to pull the patches out of email.

On Thu, May 18, 2017 at 05:16:40PM +0800, Song Xiaowei wrote:
> +/* info lacated in sysctrl */

s/lacated/located/

> +/*peri_crg ctrl*/

Add spaces after "/*" and before "*/" (also fix other occurrences below).

> +static int __init kirin_add_pcie_port(struct dw_pcie *pci,
> + struct platform_device *pdev)
> +{
> + int ret;
> +
> + pci->pp.ops = &kirin_pcie_host_ops;
> +
> + ret = dw_pcie_host_init(&pci->pp);
> +
> + return ret;

return dw_pcie_host_init(&pci->pp);

and get rid of "ret" altogether.

> +}

> + ret = kirin_add_pcie_port(pci, pdev);
> + if (ret)
> + return ret;
> +
> + return 0;

return kirin_add_pcie_port(pci, pdev);

> +}

\
 
 \ /
  Last update: 2017-05-23 23:31    [W:0.046 / U:1.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site