lkml.org 
[lkml]   [2017]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 073/103] [media] dib0700: fix NULL-deref at probe
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Johan Hovold <johan@kernel.org>

    commit d5823511c0f8719a39e72ede1bce65411ac653b7 upstream.

    Make sure to check the number of endpoints to avoid dereferencing a
    NULL-pointer should a malicious device lack endpoints.

    Fixes: c4018fa2e4c0 ("[media] dib0700: fix RC support on Hauppauge
    Nova-TD")

    Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
    Signed-off-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/media/usb/dvb-usb/dib0700_core.c | 3 +++
    1 file changed, 3 insertions(+)

    --- a/drivers/media/usb/dvb-usb/dib0700_core.c
    +++ b/drivers/media/usb/dvb-usb/dib0700_core.c
    @@ -783,6 +783,9 @@ int dib0700_rc_setup(struct dvb_usb_devi

    /* Starting in firmware 1.20, the RC info is provided on a bulk pipe */

    + if (intf->altsetting[0].desc.bNumEndpoints < rc_ep + 1)
    + return -ENODEV;
    +
    purb = usb_alloc_urb(0, GFP_KERNEL);
    if (purb == NULL) {
    err("rc usb alloc urb failed");

    \
     
     \ /
      Last update: 2017-05-23 23:01    [W:4.193 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site