lkml.org 
[lkml]   [2017]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/24] thunderbolt: Do not try to read UID if DROM offset is read as 0
    On Mon, May 22, 2017 at 08:41:22PM +0200, Andreas Noever wrote:
    > Yes there is a check for the root switch, but also one that checks the
    > return code of tb_drom_read_uid_only :)
    >
    > err = tb_drom_read_uid_only(sw, &uid);
    > if (err) {
    > tb_sw_warn(sw, "uid read failed\n");
    > return err;
    > }
    > if (sw != sw->tb->root_switch && sw->uid != uid) {
    >
    >
    > The reason it works on the Mac is because drom_offset is not 0, so the
    > new branch in tb_drom_read_uid_only is not taken. Probably this is the
    > case for all Cactus Ridge models and Alpine Ridge doesn't go there
    > since it uses the ICM?

    Yes in case of ICM we don't call the function at all.

    > Still it wouldn't hurt to only read the uid if
    > sw != root_switch, the value is not used if sw == root_switch.

    I agree. I'll update the code so that it will only read and check UID
    when we are not dealing with the root switch.

    \
     
     \ /
      Last update: 2017-05-22 22:41    [W:3.259 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site