Messages in this thread | | | Date | Mon, 22 May 2017 07:56:54 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH v2 3/5] ARM: OMAP2+: pm33xx-core: Add platform code needed for PM |
| |
Hi,
* Dave Gerlach <d-gerlach@ti.com> [170519 13:08]: > In addition to this, to be able to share data structures between C and > the sleep33xx and sleep43xx assembly code, we can automatically generate > all of the C struct member offsets and sizes as macros by making use of > the ARM asm-offsets file. In the same header that we define our data > structures in we also define all the macros in an inline function and by > adding a call to this in the asm_offsets file all macros are properly > generated and available to the assembly code without cluttering up the > asm-offsets file. ... > diff --git a/arch/arm/kernel/asm-offsets.c b/arch/arm/kernel/asm-offsets.c > index d728b5660e36..62253e7bfac4 100644 > --- a/arch/arm/kernel/asm-offsets.c > +++ b/arch/arm/kernel/asm-offsets.c > @@ -28,6 +28,7 @@ > #include <asm/vdso_datapage.h> > #include <asm/hardware/cache-l2x0.h> > #include <linux/kbuild.h> > +#include <linux/platform_data/pm33xx.h> > #include <linux/ti-emif-sram.h> > > /* > @@ -187,6 +188,7 @@ int main(void) > #if defined(CONFIG_SOC_AM33XX) || defined(CONFIG_SOC_AM43XX) > BLANK(); > ti_emif_offsets(); > + amx3_pm_asm_offsets(); > #endif > > return 0;
Russell, care to take a look at the above if you're OK with it or if you prefer to do it some other way?
Also please see thread "[PATCH v2 0/2] memory: Introduce ti-emif-sram driver" for similar changes.
Thanks,
Tony
| |