Messages in this thread | | | Subject | Re: [PATCH v6] mfd: Add Cherry Trail Whiskey Cove PMIC driver | From | Hans de Goede <> | Date | Sun, 21 May 2017 11:51:43 +0200 |
| |
Hi,
On 20-05-17 21:26, Paul Gortmaker wrote: > On Sat, May 20, 2017 at 3:21 PM, Paul Gortmaker > <paul.gortmaker@windriver.com> wrote: >> On Mon, May 15, 2017 at 2:20 PM, Hans de Goede <hdegoede@redhat.com> wrote: >>> Hi, >>> >>> This is actually v7, with the following changes: >>> >>> Changes in v7: >>> -Add explanation why this is a bool and why it selects i2c-designwaree > > Gah -- I missed the explanation mentioned above: > > -Change Kconfig option from tristate to boolean and add a select for the > i2c-bus driver, this is necessary because the chtwc PMIC provides an ACPI > OPRegion handler, which must be available before other drivers using it > are loaded, which can only be ensured if the mfd, opregion and i2c-bus > drivers are built in > > Given that, can we get rid of the modular macros in the code now as well?
Yes we can, to be clear you are talking about dropping:
MODULE_DEVICE_TABLE(i2c, cht_wc_i2c_id); MODULE_DEVICE_TABLE(acpi, cht_wc_acpi_ids); MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Hans de Goede <hdegoede@redhat.com>");
And replacing:
module_i2c_driver(cht_wc_driver);
with:
builtin_i2c_driver(cht_wc_driver);
Right ?
Anything I'm missing ?
If not I will post a new version with these removed / replaced.
Regards,
Hans
| |