Messages in this thread | | | From | Kees Cook <> | Date | Sat, 20 May 2017 16:46:20 -0700 | Subject | Re: [PATCH] Make x86 use $TARGET-readelf like all the other arches. |
| |
On Sat, May 20, 2017 at 1:03 PM, Rob Landley <rob@landley.net> wrote: > From: Rob Landley <rob@landley.net> > > My cross-compile environment doesn't provide an unprefixed > readelf in the $PATH, which works fine on every target but x86, > where you get a bunch of "/bin/sh: 1: readelf: not found" > messages (but the result still works anyway). > > Signed-off-by: Rob Landley <rob@landley.net>
Ooops, thanks for the catch!
Acked-by: Kees Cook <keescook@chromium.org>
-Kees
> --- > > arch/x86/boot/compressed/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/boot/compressed/Makefile b/arch/x86/boot/compressed/Makefile > index 44163e8..2c860ad 100644 > --- a/arch/x86/boot/compressed/Makefile > +++ b/arch/x86/boot/compressed/Makefile > @@ -94,7 +94,7 @@ vmlinux-objs-$(CONFIG_EFI_MIXED) += $(obj)/efi_thunk_$(BITS).o > quiet_cmd_check_data_rel = DATAREL $@ > define cmd_check_data_rel > for obj in $(filter %.o,$^); do \ > - readelf -S $$obj | grep -qF .rel.local && { \ > + ${CROSS_COMPILE}readelf -S $$obj | grep -qF .rel.local && { \ > echo "error: $$obj has data relocations!" >&2; \ > exit 1; \ > } || true; \
-- Kees Cook Pixel Security
| |