Messages in this thread | | | From | Arnd Bergmann <> | Date | Sat, 20 May 2017 21:10:59 +0200 | Subject | Re: [PATCH] lpfc: nvmet_fc: fix format string |
| |
On Sat, May 20, 2017 at 12:28 PM, Joe Perches <joe@perches.com> wrote: > On Fri, 2017-05-19 at 10:04 +0200, Arnd Bergmann wrote: >> The lpfc_nvmeio_data() tracing helper always takes a format string and >> three additional arguments. > > No it doesn't. It takes a format and arguments. > > I don't disagree with the patch, just the characterization > of the lpfc_mvmeio_data call in the commit message.
I think my description is correct, it's just not obvious from reading the code until you also look at the lpfc_debugfs_nvme_trc prototype:
extern void lpfc_debugfs_nvme_trc(struct lpfc_hba *phba, char *fmt, uint16_t data1, uint16_t data2, uint32_t data3); #define lpfc_nvmeio_data(phba, fmt, arg...) \ { \ if (phba->nvmeio_trc_on) \ lpfc_debugfs_nvme_trc(phba, fmt, ##arg); \ }
This is trying to do the same thing as the regular Linux tracepoints, but is called in a lot of places that are all required to pass exactly three integer arguments along with a matching format string.
Arnd
| |