Messages in this thread | | | Date | Sat, 20 May 2017 18:53:45 +0200 | From | Christoph Hellwig <> | Subject | Re: [REGRESSION] Failed network caused by: xhci: switch to pci_alloc_irq_vectors |
| |
On Sat, May 20, 2017 at 09:49:56AM -0700, Linus Torvalds wrote: > Side note: why is it doing that " > 1" check, when any value _other_ > than 1 is wrong?
It's the same effect, so either one is fine with me.
> Also, to match the non-MSI implementation, wouldn't it be nicer to > just write it that same way (and also verify "dev->irq"): > > if (flags & PCI_IRQ_LEGACY) { > if (min_vecs == 1 && dev->irq) > return 1; > } > return -ENOSPC; > > (the exact error value probably doesn't matter in practice, but the > CONFIG_MSI case returns ENOSPC by default and that's what > Documentation/PCI/MSI-HOWTO.txt says too).
Sure. Just sent the previous version to Bjorn so that he could maybe make it for -rc2, but I'll respin it.
| |