Messages in this thread | | | From | NeilBrown <> | Date | Wed, 03 May 2017 07:47:29 +1000 | Subject | Re: [PATCH 02/13] blk: replace bioset_create_nobvec() with a flags arg to bioset_create() |
| |
On Tue, May 02 2017, Christoph Hellwig wrote:
>> diff --git a/include/linux/bio.h b/include/linux/bio.h >> index d1b04b0e99cf..0975da6bebd9 100644 >> --- a/include/linux/bio.h >> +++ b/include/linux/bio.h >> @@ -373,8 +373,10 @@ static inline struct bio *bio_next_split(struct bio *bio, int sectors, >> return bio_split(bio, sectors, gfp, bs); >> } >> >> -extern struct bio_set *bioset_create(unsigned int, unsigned int); >> -extern struct bio_set *bioset_create_nobvec(unsigned int, unsigned int); >> +extern struct bio_set *bioset_create(unsigned int, unsigned int, int flags); >> +enum { >> + BIOSET_NEED_BVECS = BIT(0), >> +}; > > I really hate the BIT macro as it obsfucates what's going on.
So post a patch to remove it from the tree. I happen to like it, but I wouldn't fight for it.
> > Why not just > > BIOSET_NEED_BVECS = (1 << 0), > > which is a lot more intuitive. > > Otherwise looks fine to me: > > Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks, NeilBrown [unhandled content-type:application/pgp-signature] | |