Messages in this thread | | | Date | Tue, 2 May 2017 11:06:38 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH] serdev: Restore serdev_device_write_buf for atomic context |
| |
On Fri, Apr 28, 2017 at 01:47:21PM +0200, Stefan Wahren wrote: > Starting with commit 6fe729c4bdae ("serdev: Add serdev_device_write > subroutine") the function serdev_device_write_buf cannot be used in > atomic context anymore (mutex_lock is sleeping). So restore the old > behavior.
Yeah, preventing use in atomic context seems unnecessary, although any clients writing must now deal with serialisation themselves (as before, and as they should).
Calling wait_for_completion in the non-blocking case was also needlessly inefficient.
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com> > Fixes: 6fe729c4bdae ("serdev: Add serdev_device_write subroutine")
Reviewed-by: Johan Hovold <johan@kernel.org>
Thanks, Johan
| |