Messages in this thread | | | Date | Fri, 19 May 2017 09:19:22 +0200 | From | Maxime Ripard <> | Subject | Re: [linux-sunxi] [PATCH v6 9/9] arm64: allwinner: a64: enable Wi-Fi for Pine64 |
| |
On Fri, May 19, 2017 at 11:03:33AM +0800, Icenowy Zheng wrote: > >The patch looks OK, but given the module is removable, I think it > >should be > >an overlay. The overlay would enable WiFi + Bluetooth, and all the > >peripherals needed to connect them. > > > >That way, if the module is not installed, we avoid confusing the user > >with > >unused peripherals, and avoid having live voltage on an unoccupied > >header. > > But as this header have specific usage, we will also confuse user > if it's not enabled as its target usage.
Yet you would enable unused resources.
This was already pointed out here: https://patchwork.kernel.org/patch/9670235/
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |