lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm: clarify why we want kmalloc before falling backto vmallock
From
Date
On 05/17/2017 01:09 AM, Michal Hocko wrote:
> From: Michal Hocko <mhocko@suse.com>
>
> While converting drm_[cm]alloc* helpers to kvmalloc* variants Chris
> Wilson has wondered why we want to try kmalloc before vmalloc fallback
> even for larger allocations requests. Let's clarify that one larger
> physically contiguous block is less likely to fragment memory than many
> scattered pages which can prevent more large blocks from being created.
>
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/util.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/mm/util.c b/mm/util.c
> index 464df3489903..87499f8119f2 100644
> --- a/mm/util.c
> +++ b/mm/util.c
> @@ -357,7 +357,10 @@ void *kvmalloc_node(size_t size, gfp_t flags, int node)
> WARN_ON_ONCE((flags & GFP_KERNEL) != GFP_KERNEL);
>
> /*
> - * Make sure that larger requests are not too disruptive - no OOM
> + * We want to attempt a large physically contiguous block first because
> + * it is less likely to fragment multiple larger blocks and therefore
> + * contribute to a long term fragmentation less than vmalloc fallback.
> + * However make sure that larger requests are not too disruptive - no OOM
> * killer and no allocation failure warnings as we have a fallback
> */

Thanks for adding this, it's great to have. Here's a slightly polished version of your words, if you
like:

/*
* We want to attempt a large physically contiguous block first because
* it is less likely to fragment multiple larger blocks. This approach
* therefore contributes less to long term fragmentation than a vmalloc
* fallback would. However, make sure that larger requests are not too
* disruptive: no OOM killer and no allocation failure warnings, as we
* have a fallback.
*/

thanks,
john h

> if (size > PAGE_SIZE) {
> --
> 2.11.0
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>

\
 
 \ /
  Last update: 2017-05-20 02:47    [W:0.078 / U:0.008 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site