lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] Use ctlr directly in rdac_failover_get()
Date
On Fri, 2017-05-19 at 14:06 +0200, Artem Savkov wrote:
> rdac_failover_get references struct rdac_controller as
> ctlr->ms_sdev->handler_data->ctlr for no apparent reason. Besides being
> inefficient this also introduces a null-pointer dereference as
> send_mode_select() sets ctlr->ms_sdev to NULL before calling
> rdac_failover_get():
>
> [ ... ]
> Signed-off-by: Artem Savkov <asavkov@redhat.com>

Hello Artem,

Although this patch looks fine to me, please consider adding the "Fixes:" and
"Cc: <stable@vger.kernel.org>" tags.

Bart.
\
 
 \ /
  Last update: 2017-05-20 00:25    [W:0.058 / U:2.612 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site