lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] iio: light: isl29018: Only declare ACPI table when ACPI is enabled
On Fri, May 19, 2017 at 2:28 PM, Matthias Kaehlcke <mka@chromium.org> wrote:
> This fixes the following warning when building with clang:
>
> drivers/iio/light/isl29018.c:808:36: error: variable
> 'isl29018_acpi_match' is not needed and will not be emitted
> [-Werror,-Wunneeded-internal-declaration]
>
> Signed-off-by: Matthias Kaehlcke <mka@chromium.org>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

> ---
> drivers/iio/light/isl29018.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/light/isl29018.c b/drivers/iio/light/isl29018.c
> index 917dd8b43e72..61f5924b472d 100644
> --- a/drivers/iio/light/isl29018.c
> +++ b/drivers/iio/light/isl29018.c
> @@ -807,6 +807,7 @@ static SIMPLE_DEV_PM_OPS(isl29018_pm_ops, isl29018_suspend, isl29018_resume);
> #define ISL29018_PM_OPS NULL
> #endif
>
> +#ifdef CONFIG_ACPI
> static const struct acpi_device_id isl29018_acpi_match[] = {
> {"ISL29018", isl29018},
> {"ISL29023", isl29023},
> @@ -814,6 +815,7 @@ static const struct acpi_device_id isl29018_acpi_match[] = {
> {},
> };
> MODULE_DEVICE_TABLE(acpi, isl29018_acpi_match);
> +#endif
>
> static const struct i2c_device_id isl29018_id[] = {
> {"isl29018", isl29018},
> --
> 2.13.0.303.g4ebf302169-goog
>

\
 
 \ /
  Last update: 2017-05-19 23:58    [W:0.034 / U:2.436 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site