[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH] aoe: harmless underflow in minor_get_static()
The "aoemin" comes from revalidate() in drivers/block/aoe/aoechr.c.  It
can be negative. We cap the upper bound but not the lower bound so
that's an underflow bug. But it doesn't matter because we check "n"
against N_DEVS so it all works out fine in the end.

Anyway, let's silence the static checker warning.

Signed-off-by: Dan Carpenter <>

diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index ffd1947500c6..eddd0ecc9e0b 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -58,7 +58,7 @@ minor_get_dyn(ulong *sysminor)

static int
-minor_get_static(ulong *sysminor, ulong aoemaj, int aoemin)
+minor_get_static(ulong *sysminor, ulong aoemaj, unsigned int aoemin)
ulong flags;
ulong n;
 \ /
  Last update: 2017-05-19 23:29    [W:0.029 / U:0.468 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site