lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2 1/3] ACPI / EC: Enhance boot EC sanity check
Date
It's reported that some buggy BIOS tables can contain 2 DSDT ECs and one of
them is invalid. As we shouldn't evaluate _STA from acpi_ec_dsdt_probe()
due to the unknown Windows enumeration order, this patch simply enhances
sanity checks in ec_parse_device() as a workaround to skip probing wrong
namespace ECs.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=195651
Tested-by: Daniel Drake <drake@endlessm.com>
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
---
drivers/acpi/ec.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index c24235d..a920db6 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -1362,6 +1362,14 @@ ec_parse_device(acpi_handle handle, u32 Level, void *context, void **retval)
ec_parse_io_ports, ec);
if (ACPI_FAILURE(status))
return status;
+ /*
+ * It's better to evaluate _STA to determine if the device is
+ * valid. But that could potentially trigger issues related to
+ * the unknown orders of _INI/_STA evaluations.
+ * However we can abort due to invalid _CRS information here.
+ */
+ if (ec->data_addr == 0 || ec->command_addr == 0)
+ return AE_OK;

/* Get GPE bit assignment (EC events). */
/* TODO: Add support for _GPE returning a package */
--
2.7.4
\
 
 \ /
  Last update: 2017-05-19 09:08    [W:0.092 / U:1.880 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site