lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: bcm2835-audio: bcm2835_ctl.c: Fixed a comment coding style issue
On Sat, May 20, 2017 at 01:00:17AM +0530, srishti sharma wrote:
> Was the format of this patch acceptable ,the "from" matches the
> "signed-off-by" right , so this should be correct , were there any
> errors in this ? Should I resend it ?
>
> Regards,
> Srishti
>

You should capitalize your name in both since you're doing that here.

Also I really think you can figure out how to fix your email headers so
you don't need to use a From header. Lots of people use gmail and they
were able to figure it out.

But yeah, the way you sent it is also fine.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-05-19 21:35    [W:0.061 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site