Messages in this thread | | | Date | Fri, 19 May 2017 15:21:46 -0400 | From | Tejun Heo <> | Subject | Re: [RFC PATCH v2 08/17] cgroup: Move debug cgroup to its own file |
| |
Hello, Waiman.
On Thu, May 18, 2017 at 11:52:18AM -0400, Waiman Long wrote: > The controller name is "debug" and so it is obvious what this controller > is for. However, the config prompt "Example controller" is indeed vague
Yeah but it also shows up as an integral part of stable interface rather than e.g. /sys/kernel/debug. This isn't of any interest to people who aren't developing cgroup core code. There is no reason to risk growing dependencies on it.
> in meaning. So we can make the prompt more descriptive here. As for the > boot param, are you saying something like "cgroup_debug" has to be > specified in the command line even if CGROUP_DEBUG config is there for > the debug controller to be enabled? I am fine with that if you think it > is necessary.
Yeah, I think that'd be a good idea. cgroup_debug should do. While at it, can you also please make CGROUP_DEBUG depend on DEBUG_KERNEL?
Thanks.
-- tejun
| |