lkml.org 
[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH][drm-next] drm/pl111: make structure pl111_display_funcs static
Date
Jani Nikula <jani.nikula@linux.intel.com> writes:

> On Fri, 19 May 2017, Colin King <colin.king@canonical.com> wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> structure pl111_display_funcs can be made static as it does not need to be
>> in global scope. Fixes sparse warning:
>>
>> "warning: symbol 'pl111_display_funcs' was not declared. Should it
>> be static?"
>>
>> Fixes: bed41005e6174d ("drm/pl111: Initial drm/kms driver for pl111")
>
> The patch looks good and I appreciate what you're doing, but I question
> the usefulness of adding Fixes: tags for trivial stuff like this. I'd
> prefer Fixes: was reserved for actual fixes that should be backported to
> any kernels that have the commit being fixed.

Agreed -- since Fixes implies going to stable, we don't want it on
non-stable-candidates like this. Reviewed these two and will push
without the tag in a moment.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2017-05-19 20:19    [W:0.071 / U:0.488 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site