[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe
On Fri, May 19, 2017 at 10:18:34AM -0400, Keith Busch wrote:
> +
> + if (ns->ctrl->quirks & NVME_QUIRK_PAGE_ALIGN)
> + blk_queue_logical_block_size(ns->queue, ns->ctrl->page_size);
> + else
> + blk_queue_logical_block_size(ns->queue, bs);

Ugg. That will invalidate the layout of any existing fs (in case the
device hasn't eaten it yet). It would also invalidate things like
partitions tables, even if they are only used to share with windows.

 \ /
  Last update: 2017-05-19 16:16    [W:0.038 / U:18.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site