[lkml]   [2017]   [May]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] staging: iio: light: Replace symbolic permissions as per coding style
On Fri, May 19, 2017 at 01:42:55PM +0530, wrote:
> -static DEVICE_ATTR(power_state, S_IRUGO | S_IWUSR,
> - tsl2x7x_power_state_show, tsl2x7x_power_state_store);
> +static DEVICE_ATTR_RW(tsl2x7x_power_state);

You do realize you just renamed the sysfs file, changing the user/kernel
api? That's generally not a good thing to ever do :(


greg k-h

 \ /
  Last update: 2017-05-19 10:22    [W:0.056 / U:1.936 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site