Messages in this thread Patch in this message | | | From | Jan Kiszka <> | Subject | [PATCH v2 3/6] gpio: exar: Fix iomap request | Date | Thu, 18 May 2017 16:59:06 +0200 |
| |
The UART driver already maps the resource for us. Trying to do this here only fails and leaves us with a non-working device.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/gpio/gpio-exar.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpio/gpio-exar.c b/drivers/gpio/gpio-exar.c index b1dc5fff21ad..4ed1f8bdeda7 100644 --- a/drivers/gpio/gpio-exar.c +++ b/drivers/gpio/gpio-exar.c @@ -130,14 +130,10 @@ static int gpio_exar_probe(struct platform_device *pdev) return -ENODEV; /* - * Map the pci device to get the register addresses. - * We will need to read and write those registers to control - * the GPIO pins. - * Using managed functions will save us from unmaping on exit. - * As the device is enabled using managed functions by the - * UART driver we can also use managed functions here. + * The UART driver must have mapped region 0 prior to registering this + * device - use it. */ - p = pcim_iomap(pcidev, 0, 0); + p = pcim_iomap_table(pcidev)[0]; if (!p) return -ENOMEM; -- 2.12.0
| |